8000 Use $_SERVER[ 'SERVER_PROTOCOL' ] to determine correct HTTP protocol … · Pull Request #413 · Automattic/wp-super-cache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use $_SERVER[ 'SERVER_PROTOCOL' ] to determine correct HTTP protocol … #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Oct 20, 2017
Merged

Use $_SERVER[ 'SERVER_PROTOCOL' ] to determine correct HTTP protocol … #413

merged 2 commits into from Oct 20, 2017

Conversation

ghost
Copy link
@ghost ghost commented Oct 11, 2017

…version for response headers

See: http://php.net/manual/en/function.header.php#92305

(Last change I needed to propose.)

@ghost
Copy link
Author
ghost commented Oct 12, 2017

@donnchawp

@alexsanford
Copy link

This looks good to me. It's worth noting that nginx (and probably other webservers as well) seems to automatically change the protocol to HTTP/1.1, regardless of what PHP specifies. But I tested this manually with php -S and it works great!

Thanks, @robjarsen !

@alexsanford alexsanford merged commit c5c9b43 into Automattic:master Oct 20, 2017
@alexsanford alexsanford added this to the 1.5.7.2 milestone Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.
1 participant
@alexsanford
0