Less aggressive security margin for otf payments #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liquidity fees depend on mining fees which are volatile, and may increase between the time when a user accepts otf liquidity, and the time when the LSP allocates the liquidity. We need to make sure that the user is able to afford the increase of cost, so we require the incoming payment + fee credit to be 2x the estimated fee. But that is overkill because only the mining fee is volatile, not the liquidity fee. On top of that, the liquidity fee can be much greater than the mining fee for some use cases (e.g. phoenixd).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquidity fees depend on mining fees which are volatile, and may increase between the time when a user accepts otf liquidity, and the time when the LSP allocates the liquidity. We need to make sure that the user is able to afford the increase of cost, so we require the incoming payment + fee credit to be 2x the estimated fee.
But that is overkill because only the mining fee is volatile, not the liquidity fee. On top of that, the liquidity fee can be much greater than the mining fee for some use cases (e.g. phoenixd).