8000 Add MultiTransaction type and one new web api to handle this by eanzhao · Pull Request #3613 · AElfProject/AElf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add MultiTransaction type and one new web api to handle this #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2024
Merged

Add MultiTransaction type and one new web api to handle this #3613

merged 7 commits into from
Sep 30, 2024

Conversation

eanzhao
Copy link
Contributor
@eanzhao eanzhao commented Sep 25, 2024

For Issue: #3612

@vizipi Vizipi
Copy link
vizipi bot commented Sep 25, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
50.00% jason-hoopox 20 4
25.00% ZhangXin 12 2
25.00% chopin.fan 3 2
12.50% gldeng 5 1
12.50% fengyan2023 4 1
12.50% louis.li 2 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/token_contract.proto50.00%1 out of 2 times
...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer50.00%1 out of 2 times
contract/AElf.Contracts.Genesis/BasicContractZero.cs50.00%1 out of 2 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs50.00%1 out of 2 times
contract/AElf.Contracts.MultiToken/TokenContract_Fees.cs50.00%1 out of 2 times
src/AElf.Runtime.CSharp/Executive.cs50.00%1 out of 2 times
...src/AElf.Kernel.SmartContract/HostSmartContractBridgeCont50.00%1 out of 2 times
...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe50.00%1 out of 2 times
protobuf/election_contract.proto50.00%1 out of 2 times
contract/AElf.Contracts.MultiToken/TokenContractState.cs50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 81.20%[src/AElf.WebApp.Application.Chain/Error.cs]
  • 90.76%[...src/AElf.WebApp.Application.Chain/Services/TransactionApp]
  • 88.41%[...src/AElf.WebApp.Application.Chain/ChainApplicationWebAppA]
  • 0.00%[...src/AElf.WebApp.Application.Chain/MultiTransactionOptions]
  • 98.47%[protobuf/aelf/core.proto]
  • 0.00%[...src/AElf.WebApp.Application.Chain/Dto/SendMultiTransactio]
  • 0.00%[...src/AElf.WebApp.Application.Chain/Dto/SendMultiTransactio]
  • 0.00%[src/AElf.Types/Types/MultiTransaction.cs]

    • @codecov Codecov
    Copy link
    codecov bot commented Sep 25, 2024 •
    edited
    Loading

    Codecov Report

    Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

    Project coverage is 90.53%. Comparing base (813c602) to head (6912ed3).
    Report is 8 commits behind head on dev.

    Files with missing lines Patch % Lines
    src/AElf.Types/Types/MultiTransaction.cs 0.00% 31 Missing ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
##              dev    #3613      +/-   ##
==========================================
- Coverage   90.63%   90.53%   -0.10%     
==========================================
  Files         676      677       +1     
  Lines       26067    26104      +37     
  Branches     2346     2353       +7     
==========================================
+ Hits        23626    23634       +8     
- Misses       2326     2355      +29     
  Partials      115      115
    Flag Coverage Δ
    90.53% <20.51%> (?)

    Flags with carried forward coverage won't be shown. Click here to find out more.

    Files with missing lines Coverage Δ
    ...lication.Chain/ChainApplicationWebAppAElfModule.cs 100.00% <100.00%> (ø)
    src/AElf.WebApp.Application.Chain/Error.cs 100.00% <100.00%> (ø)
    ...pplication.Chain/Services/TransactionAppService.cs 94.87% <100.00%> (+0.27%) ⬆️
    src/AElf.Types/Types/MultiTransaction.cs 0.00% <0.00%> (ø)

    ... and 1 file with indirect coverage changes

    @JimAelf JimAelf merged commit 88d4e10 into dev Sep 30, 2024
    9 of 12 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JimAelf JimAelf JimAelf approved these changes

    @chopin-fan chopin-fan chopin-fan approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @eanzhao @JimAelf @chopin-fan
    0