8000 Add object safe APIs to the adapters by mikayla-maki · Pull Request #563 · AccessKit/accesskit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add object safe APIs to the adapters #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add object safe APIs to the adapters #563

wants to merge 1 commit into from

Conversation

mikayla-maki
Copy link

Hello!

In GPUI, we use an object safe platform abstraction, which is incompatible with the existing update_if_active APIs. This PR fixes this by introducing 2 new methods that allow us to re-implement update_if_active at a higher level:

  • active(&self) -> bool
  • pub fn update(&mut self, update: TreeUpdate) -> Option<QueuedEvents>

@mikayla-maki mikayla-maki force-pushed the add-object-safe-apis branch from 638c16b to c8c0568 Compare May 16, 2025 10:25
@DataTriny
Copy link
Member

Hi @mikayla-maki,

This does not feel right to me. Could you please show how you plan to use this?

Have you looked at the accesskit_winit crate (in platforms/winit), to see a similar implementation of what you are likely trying to build?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikayla-maki @DataTriny
0