8000 fix(exception): handle ServerWebInputException by Ahoo-Wang · Pull Request #1490 · Ahoo-Wang/Wow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(exception): handle ServerWebInputException #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

fix(exception): handle ServerWebInputException #1490

merged 2 commits into from
May 15, 2025

Conversation

Ahoo-Wang
Copy link
Owner
  • Add handling for ServerWebInputException in GlobalExceptionHandler
  • Implement toInputErrorInfo() extension function for ServerWebInputException
  • Update RequestExceptionHandler to handle ServerWebInputException
  • Add unit tests for ServerWebInputException handling

@Ahoo-Wang
fix(exception): handle ServerWebInputException
253f832 
- Add handling for ServerWebInputException in GlobalExceptionHandler
- Implement toInputErrorInfo() extension function for ServerWebInputException
- Update RequestExceptionHandler to handle ServerWebInputException
- Add unit tests for ServerWebInputException handling

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 15, 2025 •
edited
Loading

Test Results

1 339 tests  +4   1 322 ✅ +4   12m 4s ⏱️ +52s
  343 suites +1      17 💤 ±0 
  343 files   +1       0 ❌ ±0 

Results for commit 2f4db38. ± Comparison against base commit 40d5ba5.

♻️ This comment has been updated with latest results.

@Ahoo-Wang
test(exception): update error code in GlobalExceptionHandlerTest
2f4db38 
- Change the error code in the test from NOT_FOUND to ILLEGAL_ARGUMENT
- Update the corresponding verification to match the new error code

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (40d5ba5) to head (2f4db38).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...oo/wow/webflux/exception/GlobalExceptionHandler.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1490      +/-   ##
============================================
+ Coverage     90.95%   90.96%   +0.01%     
- Complexity     3492     3493       +1     
============================================
  Files           657      657              
  Lines         12081    12089       +8     
  Branches        778      781       +3     
============================================
+ Hits          10988    10997       +9     
+ Misses          719      718       -1     
  Partials        374      374
Flag Coverage Δ
unittests 90.96% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit 9a01957 into main May 15, 2025
32 checks passed
@Ahoo-Wang Ahoo-Wang deleted the ServerWebInputException branch May 15, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang
0