8000 feat(webflux): add NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter by Ahoo-Wang · Pull Request #1492 · Ahoo-Wang/Wow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(webflux): add NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

feat(webflux): add NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter #1492

merged 3 commits into from
May 15, 2025

Conversation

Ahoo-Wang
Copy link
Owner
@Ahoo-Wang Ahoo-Wang commented May 15, 2025 •
edited
Loading
  • remove ErrorInfo transformation logic from DefaultErrorConverter
  • add ErrorInfo materialize method calls to ErrorConverterRegistrar
  • separate handling logic for specific exception types into separate Converter
  • update GlobalExceptionHandler and RequestExceptionHandler to use new Converter
  • add HandlerMethodValidationExceptionConverter, NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter

@Ahoo-Wang
refactor(webflux): Refactoring exception handling logic
f378734 
- remove ErrorInfo transformation logic from DefaultErrorConve
8000
rter
- add ErrorInfo materialize method calls to ErrorConverterRegistrar-separating handling logic for specific exception types into separate Converter
- update GlobalExceptionHandler and RequestExceptionHandler to use new Converter
- add HandlerMethodValidationExceptionConverter, NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label May 15, 2025
@Ahoo-Wang Ahoo-Wang changed the title refactor(webflux): Refactoring exception handling logic refactor(webflux): add HandlerMethodValidationExceptionConverter, NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter May 15, 2025
@Ahoo-Wang Ahoo-Wang changed the title refactor(webflux): add HandlerMethodValidationExceptionConverter, NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter feat(webflux): add NoResourceFoundExceptionConverter, and ServerWebInputExceptionConverter May 15, 2025
Ahoo-Wang added 2 commits May 15, 2025 13:56
@Ahoo-Wang
build: update project version to 5.13.5
153b81b 
- Changed version from 5.13.3 to 5.13.5 in gradle.properties

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang
refactor(exception): improve error converter naming for clarity
5d25f41 
- Rename `errorInfoConverter` to `errorConverter` for better readability
- Maintain existing functionality while enhancing code understandability

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 15, 2025 •
edited
Loading

Test Results

1 334 tests  ±0   1 317 ✅ ±0   11m 14s ⏱️ -47s
  343 suites ±0      17 💤 ±0 
  343 files   ±0       0 ❌ ±0 

Results for commit 5d25f41. ± Comparison against base commit dd90897.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (dd90897) to head (5d25f41).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ption/HandlerMethodValidationExceptionConverter.kt 81.81% 0 Missing and 2 partials ⚠️
...flux/exception/ServerWebInputExceptionConverter.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1492   +/-   ##
=========================================
  Coverage     90.96%   90.96%           
  Complexity     3493     3493           
=========================================
  Files           658      661    +3     
  Lines         12083    12086    +3     
  Branches        777      772    -5     
=========================================
+ Hits          10991    10994    +3     
  Misses          718      718           
  Partials        374      374
Flag Coverage Δ
unittests 90.96% <88.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit 5c63dc8 into main May 15, 2025
32 checks passed
@Ahoo-Wang Ahoo-Wang deleted the exception-handling-logic branch May 15, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang
0