Fix #58 - add carousel css to webpack, add the css to the Enqueue #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueue.php class
|
How does this work differently if enqueued in the styles.scss like the normalize file? I am thinking of less network calls with one file. |
|
@bahiirwa Yes, that would reduce a network call. Until now, I didn't realize you could reference node_modules with the ~ operator in SASS 😲 I'll update my PR, that makes more sense. |
|
Not to worry, The Travis CI is shouting because of wp_dangit on header.php svg( ‘wordpress’ ). Need to report new issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carousel css was not previously loaded in the project, meaning that the carousel would not work out of the box in a fresh AWPS theme.