8000 Fix Time Format Error by saibotrellum · Pull Request #4 · Alex-Werner/hapi-cron-job · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Time Format Error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

Fix Time Format Error #4

merged 1 commit into from
Jan 10, 2017

Conversation

saibotrellum
Copy link
Contributor

In local timezone setting, actualTime is in 12h format as default, which doesn't correspond with internal format.
Therefore, set 24h format as defined option.

Fix Time Format Error
c2151b8 
In local timezone setting, actualTime is in 12h format as default, which doesn't correspond with our internal format.
Therefore, set 24h format as defined option.
@Alex-Werner
Copy link
Owner
Alex-Werner commented Jan 10, 2017 •
edited
Loading

Sorry, I didn't saw that earlier !
Seems good to me, I will check this properly this evening and merge it.

I want to thank you a lot for your PR on this little project. <3

@Alex-Werner
Copy link
Owner

Fixed : #2

@Alex-Werner Alex-Werner merged commit 3cae0dd into Alex-Werner:master Jan 10, 2017
@saibotrellum
Copy link
Contributor Author

Ha... I didn't even see that there was already an issue open.
Cheers!

@Alex-Werner
Copy link
Owner

Yeah, I had the same issue on a different server. I had figured out what was the problem, then forgot to indead fix it.
It was planned in a commit that has a months of delay (with a codebase clean-up, as it's a freaking mess, an internal doc 723A umentation and some new format for setting up cron - like the std cron format), but never finished as I seeked more about the Node Event Loop (a stuff I want to implement at the same time as I want to make it deterministic in order to be able to retrieve any blocking-event job done).

So thank you again for the help here :)
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saibotrellum @Alex-Werner
0