revert "refactor(net): pass request header" #8269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous changes made to passing the request header, ensuring that only internal components receive header modifications. The key changes include:
- Reverting the creation of a new header from the context value in server/common/proxy.go by using a value instead of a pointer.
- Removing header retrieval from context in internal/stream/util.go and passing nil to net.ProcessHeader.
- Adjusting the addition of the header into the context in internal/net/serve.go to store the header by value.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/common/proxy.go | Reverts header retrieval changes by directly using http.Header, ensuring compatibility with context. |
| internal/stream/util.go | Removes usage of context header; net.ProcessHeader is now called with nil as the first parameter. |
| internal/net/serve.go | Updates context assignment to store r.Header by value rather than a pointer. |
Comments suppressed due to low confidence (2)
internal/stream/util.go:22
- Ensure that net.ProcessHeader safely handles a nil request header. This is critical now that header retrieval from context has been removed.
header := net.ProcessHeader(nil, link.Header)
internal/stream/util.go:63
- Verify that net.ProcessHeader is robust against a nil header input to prevent unintended issues in header processing.
header := net.ProcessHeader(nil, link.Header)
xhofe
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream.GetRangeReadCloserFromLink只在内部使用，传递请求头好像不是个好选择😢