feat(helm): add support for rbac at namespace scope #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slach
requested changes
Apr 30, 2025
- add boolean field namespaceScoped to values.yaml to enable creation of role and rolebinding - update helm chart generation script and manifest bundle to handle creation of rbac at cluster or namespace level depending on user input - updated manifest builder script to generate rbac for namespace level Signed-off-by: dashashutosh80 <dashashutosh80@gmail.com>
419cf20 to
02a7d82
Compare
|
@Slach Please review the updated changes and let me know if anything else needs to be done. Thanks in advance! |
Slach
reviewed
May 6, 2025
Slach
requested changes
May 6, 2025
Slach
reviewed
May 7, 2025
Slach
reviewed
May 7, 2025
|
@dashashutosh80 any news from your side? could we stay ClusterRole default behavior? |
|
@Slach sorry I have been afk for a while now. I’ll update the values.yaml and readme with cluster Role as default behavior in 2-3 days. |
|
@dashashutosh80 any news from your side? |
|
@Slach Updated the values.yaml to keep namespace scoping of rbac disabled by default until user overwrites. This should not break installations during upgrade where kube-system is set as namespace and operator already runs with cluster level permissions. Please take a look |
Slach
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next-releasebranch, not intomasterbranch1. More infoThis PR contains the following changes:
This PR aims to address #1423