8000 chore(database-forwarder): ensure it works cross platform by arealmaas · Pull Request #2127 · Altinn/dialogporten · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(database-forwarder): ensure it works cross platform #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2025
Merged

chore(database-forwarder): ensure it works cross platform #2127

merged 5 commits into from
May 8, 2025

Conversation

arealmaas
Copy link
Collaborator

Description

Related Issue(s)

  • #N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested a review from a team as a code owner March 26, 2025 12:55
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Mar 26, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The pull request modifies the configure_jit_access function in the scripts/database-forwarder/forward.sh script to change the method of extracting the public IP address. The previous implementation using jq has been replaced with a combination of grep and sed for parsing. Additionally, the setup_ssh_tunnel function has been updated to include the -tt option in the az ssh vm command to enable pseudo-terminal allocation, while the error handling for IP retrieval remains unchanged.

Changes

File(s) Summary
scripts/database-forwarder/forward.sh Updated public IP extraction in configure_jit_access by replacing jq with grep and sed; added -tt option in setup_ssh_tunnel.

Possibly related PRs

Suggested reviewers

  • knuhau
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 671384f and 63ef4d3.

📒 Files selected for processing (1)
  • scripts/database-forwarder/forward.sh (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/database-forwarder/forward.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
scripts/database-forwarder/forward.sh (2)

296-297: Use of grep and sed for IP Extraction
The command now extracts the public IP address by piping the JSON output from ipinfo.io through grep and sed instead of using jq. This reduces external dependencies, which can improve portability. However, please verify that the regular expression reliably handles potential variations in JSON formatting (e.g., extra whitespace or ordering changes) returned by ipinfo.io.

295-302: Cross-Platform Availability of Text Utilities
Given the PR’s cross-platform objective, ensure that utilities like curl, grep, and sed are available and behave consistently on all target platforms. If any of these tools might be missing or have slightly different behavior (for example, on some minimal installations or non-Unix environments), consider adding fallback logic or clear error messages.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cedcd1a and 671384f.

📒 Files selected for processing (1)
  • scripts/database-forwarder/forward.sh (1 hunks)

@elsand elsand merged commit 1bff01e into main May 8, 2025
17 checks passed
@elsand elsand deleted the fix/powershell-it branch May 8, 2025 11:53
@dialogporten-bot dialogporten-bot mentioned this pull request May 8, 2025
Merged
arealmaas pushed a commit that referenced this pull request May 8, 2025
@dialogporten-bot
chore(main): release 1.65.0 (#2267)
92b3e03 
🤖 I have created a release *beep* *boop*
---


##
[1.65.0](v1.64.4...v1.65.0)
(2025-05-08)


### Features

* **infra:** add workload profiles for container apps
([#2259](#2259))
([4a5500b](4a5500b))


### Bug Fixes

* **infra:** change to workload profiles for test and yt01
([#2271](#2271))
([7feb4c0](7feb4c0))
* **infra:** Remove count from consumption workload profile
([#2268](#2268))
([ac88d85](ac88d85))
* **infra:** revert workload profiles for CAE
([#2270](#2270))
([aea9209](aea9209))


### Miscellaneous Chores

* **database-forwarder:** ensure it works cross platform
([#2127](#2127))
([1bff01e](1bff01e))
* **performance:** removed search without enduserid and use enduserid
instead of enduser
([#2263](#2263))
([2044f09](2044f09))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@elsand elsand elsand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @elsand
0