8000 fix(infra): enable workload profiles for staging and prod by arealmaas · Pull Request #2285 · Altinn/dialogporten · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(infra): enable workload profiles for staging and prod #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

fix(infra): enable workload profiles for staging and prod #2285

merged 3 commits into from
May 13, 2025

Conversation

arealmaas
Copy link
Collaborator

Description

Removing the temporary code that enabled workload profiles for test and yt01 only. Need to recreate the CAE in staging and prod for this.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested review from a team as code owners May 13, 2025 10:59
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 13, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes remove the environment parameter and associated conditional logic for workload profile configuration from multiple Bicep modules and their consumers. All references to this parameter in module instantiations and resource definitions are eliminated, resulting in unconditional workload profile assignment based solely on the provided parameters.

Changes

Files Change Summary
.azure/modules/containerApp/main.bicep
.azure/modules/containerAppJob/main.bicep		 Removed the environment parameter and conditional logic for workload profile assignment; now directly uses workloadProfileName.
.azure/modules/containerAppEnv/main.bicep Removed the environment parameter and conditional logic for workload profile filtering; now always applies provided workload profiles.
.azure/applications/graphql/main.bicep
.azure/applications/service/main.bicep
.azure/applications/web-api-eu/main.bicep
.azure/applications/web-api-so/main.bicep		 Removed environment parameter from calls to the containerApp module.
.azure/applications/sync-resource-policy-information-job/main.bicep
.azure/applications/sync-subject-resource-mappings-job/main.bicep
.azure/applications/web-api-migration-job/main.bicep		 Removed environment parameter from calls to the migrationJob module.
.azure/infrastructure/main.bicep Removed environment parameter from the containerAppEnv module instantiation.

Possibly related PRs

Suggested reviewers

  • elsand

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 13, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
.azure/modules/containerApp/main.bicep (1)

191-191: Unconditionally assign the workload profile
The workloadProfileName property is now set directly from the workloadProfileName parameter, removing the old environment‐based conditional. This aligns with the goal of enabling workload profiles in staging and prod. Consider constraining workloadProfileName with an @allowed() decorator or parameter metadata if there’s a known set of valid profiles (e.g., 'Consumption', 'Premium') to catch typos early.

.azure/modules/containerAppJob/main.bicep (1)

78-78: Simplify job workload profile configuration
The job resource now unconditionally uses the provided workloadProfileName. Verify that the default ('Consumption') makes sense for all deployment scenarios, and consider adding parameter validation (via @allowed() or custom checks) to ensure only supported profiles are passed.

.azure/modules/containerAppEnv/main.bicep (1)

69-69: Remove environment filter from workloadProfiles
By assigning workloadProfiles directly, all profiles provided will be applied regardless of environment. Confirm that callers supply the full list of desired profiles for staging and prod. You may also add schema validation for items in the workloadProfiles array to enforce required fields (name, workloadProfileType).

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3fb39e and b6a4aef.

📒 Files selected for processing (11)
  • .azure/applications/graphql/main.bicep (0 hunks)
  • .azure/applications/service/main.bicep (0 hunks)
  • .azure/applications/sync-resource-policy-information-job/main.bicep (0 hunks)
  • .azure/applications/sync-subject-resource-mappings-job/main.bicep (0 hunks)
  • .azure/applications/web-api-eu/main.bicep (0 hunks)
  • .azure/applications/web-api-migration-job/main.bicep (0 hunks)
  • .azure/applications/web-api-so/main.bicep (0 hunks)
  • .azure/infrastructure/main.bicep (0 hunks)
  • .azure/modules/containerApp/main.bicep (1 hunks)
  • .azure/modules/containerAppEnv/main.bicep (1 hunks)
  • .azure/modules/containerAppJob/main.bicep (1 hunks)
💤 Files with no reviewable changes (8)
  • .azure/applications/web-api-migration-job/main.bicep
  • .azure/infrastructure/main.bicep
  • .azure/applications/service/main.bicep
  • .azure/applications/sync-subject-resource-mappings-job/main.bicep
  • .azure/applications/web-api-eu/main.bicep
  • .azure/applications/sync-resource-policy-information-job/main.bicep
  • .azure/applications/graphql/main.bicep
  • .azure/applications/web-api-so/main.bicep
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Dry run deploy infrastructure / Deploy to test
  • GitHub Check: build / build-and-test

@elsand elsand merged commit 7827ce0 into main May 13, 2025
26 checks passed
@elsand elsand deleted the fix/enable-workload-profiles-for-prod-and-staging branch May 13, 2025 15:16
@dialogporten-bot dialogporten-bot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@elsand elsand elsand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @elsand
0