8000 ci: avoid unecessary infra and app runs on irrelevant changes by arealmaas · Pull Request #2296 · Altinn/dialogporten · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: avoid unecessary infra and app runs on irrelevant changes #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

ci: avoid unecessary infra and app runs on irrelevant changes #2296

merged 1 commit into from
May 15, 2025

Conversation

arealmaas
Copy link
Collaborator

Description

Minor changes like this one: Altinn/dialogporten-frontend#2146 shouldn't trigger a full run of infra and app deployments.

Also removed slacknotifier as it's no longer in use

Related Issue(s)

  • #N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested review from a team as code owners May 14, 2025 09:35
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 14, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The workflow configuration in .github/workflows/workflow-check-for-changes.yml was updated to remove Slack Notifier change detection, consolidate GitHub workflow file changes under a new github_workflows category, adjust infrastructure and backend change detection logic, and add detailed logging steps for changed file categories. Outputs were updated accordingly.

Changes

File(s) Change Summary
.github/workflows/workflow-check-for-changes.yml Removed Slack Notifier change detection and output; consolidated workflow file changes under github_workflows; updated infrastructure and backend change detection to include workflow files; excluded certain files from workflow detection; added detailed logging of detected changes and changed files; removed hasSlackNotifierChanges output.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 14, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/workflow-check-for-changes.yml (2)

73-77: Scope GitHub workflows detection to the workflows directory

Using '.github/**/*' with multiple exclusions can be fragile. It’s clearer to match only the workflows folder directly:

 files_yaml: |
- github_workflows:
-   - '.github/**/*'
-   - '!.github/ISSUE_TEMPLATE/**/*'
-   - '!.github/CODEOWNERS'
-   - '!.github/pull_request_template.md'
+ github_workflows:
+   - '.github/workflows/**/*'

This simplifies the pattern and removes the need for negations.

110-120: Enhance backend change logging

You’ve logged the change flags for all categories, but only listed the modified files for backend. Consider echoing the modified file lists for other backend-related categories (tests, web_api_client, swagger_schema, etc.) to mirror the infra logging step.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8e2d53 and 4e6b6da.

📒 Files selected for processing (1)
  • .github/workflows/workflow-check-for-changes.yml (3 hunks)
🔇 Additional comments (2)
.github/workflows/workflow-check-for-changes.yml (2)

47-48: Validate inclusion of GitHub workflows in infra and backend detection

The added github_workflows_any_modified flag in both hasInfraChanges and hasBackendChanges means any change to a workflow file will trigger both infrastructure and backend pipelines. Please confirm this behavior aligns with the PR objective of avoiding unnecessary infra/app runs on irrelevant changes.

79-86: Add logging for infrastructure and workflow file changes

The new log step prints both the boolean flags and the lists of modified infra and workflow files, improving visibility into what’s driving pipeline decisions.

@elsand elsand merged commit 9026eac into main May 15, 2025
26 checks passed
@elsand elsand deleted the ci/avoid-unecessary-runs branch May 15, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@elsand elsand elsand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @elsand
0