-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update Microsoft dependencies #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughMultiple project files across the solution were updated to increment the versions of various Microsoft-related NuGet packages, primarily moving from version 9.0.4 (or similar) to 9.0.5 and updating some Azure AppConfiguration and Entity Framework packages. No code, logic, or public API changes were made. Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Digdir.Domain.Dialogporten.Janitor/Digdir.Domain.Dialogporten.Janitor.csproj (1)
10-15
: Bump Microsoft.Extensions packages from 9.0.4 to 9.0.5
PackageReference versions for Hosting, Configuration, Configuration.Json, Configuration.EnvironmentVariables, Configuration.UserSecrets, and DependencyInjection have been updated to 9.0.5 to stay in sync with the solution-wide dependency upgrade. No API or config changes are expected in this patch release.Consider centralizing these version numbers in a shared
Directory.Build.props
orCentralPackageVersions.props
to avoid repeated version bumps in each csproj.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/Digdir.Domain.Dialogporten.Application/Digdir.Domain.Dialogporten.Application.csproj
(1 hunks)src/Digdir.Domain.Dialogporten.Domain/Digdir.Domain.Dialogporten.Domain.csproj
(1 hunks)src/Digdir.Domain.Dialogporten.GraphQL/Digdir.Domain.Dialogporten.GraphQL.csproj
(1 hunks)src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj
(1 hunks)src/Digdir.Domain.Dialogporten.Janitor/Digdir.Domain.Dialogporten.Janitor.csproj
(1 hunks)src/Digdir.Domain.Dialogporten.WebApi/Digdir.Domain.Dialogporten.WebApi.csproj
(1 hunks)src/Digdir.Library.Dialogporten.WebApiClient.WebApiSample/Digdir.Library.Dialogporten.WebApiClient.WebApiSample.csproj
(1 hunks)src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj
(1 hunks)src/Digdir.Library.Entity.EntityFrameworkCore/Digdir.Library.Entity.EntityFrameworkCore.csproj
(1 hunks)src/Digdir.Library.Utils.AspNet/Digdir.Library.Utils.AspNet.csproj
(1 hunks)tests/Digdir.Domain.Dialogporten.Architecture.Tests/Digdir.Domain.Dialogporten.Architecture.Tests.csproj
(1 hunks)tests/Digdir.Domain.Dialogporten.GraphQl.Integration.Tests/Digdir.Domain.Dialogporten.GraphQl.Integration.Tests.csproj
(1 hunks)tests/Digdir.Domain.Dialogporten.WebApi.Unit.Tests/Digdir.Domain.Dialogporten.WebApi.Unit.Tests.csproj
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Dry run deploy apps / Deploy web-api-so to test
- GitHub Check: Dry run deploy apps / Deploy service to test
- GitHub Check: Dry run deploy apps / Deploy graphql to test
- GitHub Check: Dry run deploy apps / Deploy web-api-eu to test
- GitHub Check: build / build-and-test
🔇 Additional comments (16)
src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj (1)
27-27
: Approve dependency version bumpThe
Microsoft.Extensions.Hosting.Abstractions
package has been updated from 9.0.4 to 9.0.5, aligning with the coordinated version upgrades across the solution. No issues detected.src/Digdir.Library.Entity.EntityFrameworkCore/Digdir.Library.Entity.EntityFrameworkCore.csproj (1)
8-8
: Upgrade of EF Core Relational package looks good
Bumping Microsoft.EntityFrameworkCore.Relational to 9.0.5 aligns with the broader set of dependency updates in this PR and should introduce no breaking changes.tests/Digdir.Domain.Dialogporten.Architecture.Tests/Digdir.Domain.Dialogporten.Architecture.Tests.csproj (1)
12-12
: Dependency update approved.Bumping
Microsoft.Build
to version17.14.8
aligns with the PR’s goal of keeping Microsoft dependencies in sync and up-to-date.tests/Digdir.Domain.Dialogporten.GraphQl.Integration.Tests/Digdir.Domain.Dialogporten.GraphQl.Integration.Tests.csproj (1)
10-10
: Approve dependency version bump for Microsoft.AspNetCore.Mvc.Testing
The package reference has been updated from 9.0.4 to 9.0.5, aligning this integration test project with the rest of the solution. This is a non-breaking patch upgrade.src/Digdir.Domain.Dialogporten.Domain/Digdir.Domain.Dialogporten.Domain.csproj (1)
5-5
: Approve version bump for Microsoft.Extensions.DependencyInjection.Abstractions
Upgrading from 9.0.4 to 9.0.5 ensures consistency across projects without affecting public APIs.tests/Digdir.Domain.Dialogporten.WebApi.Unit.Tests/Digdir.Domain.Dialogporten.WebApi.Unit.Tests.csproj (1)
9-9
: Approve dependency version bump for Microsoft.AspNetCore.Mvc.Testing
The test project now references version 9.0.5, matching other test and application projects.src/Digdir.Library.Dialogporten.WebApiClient.WebApiSample/Digdir.Library.Dialogporten.WebApiClient.WebApiSample.csproj (1)
8-8
: Approve version bump for Microsoft.AspNetCore.OpenApi
Updating from 9.0.4 to 9.0.5 keeps the sample project in sync with updated OpenAPI dependencies.src/Digdir.Domain.Dialogporten.Application/Digdir.Domain.Dialogporten.Application.csproj (1)
12-13
: Approve Microsoft.Extensions package upgrades
BothMicrosoft.Extensions.Hosting
andMicrosoft.Extensions.Options.ConfigurationExtensions
have been correctly updated from 9.0.4 to 9.0.5, maintaining consistency with related projects.src/Digdir.Library.Utils.AspNet/Digdir.Library.Utils.AspNet.csproj (1)
11-13
: Update Http and AppConfiguration packages
TheMicrosoft.Extensions.Http
package is bumped to 9.0.5 andMicrosoft.Azure.AppConfiguration.AspNetCore
to 8.2.0, aligning with the broader dependency updates. No behavioral changes are expected in these minor/patch releases.src/Digdir.Domain.Dialogporten.GraphQL/Digdir.Domain.Dialogporten.GraphQL.csproj (2)
7-7
: Upgrade JwtBearer authentication package
Microsoft.AspNetCore.Authentication.JwtBearer
moved from 9.0.4 to 9.0.5. This patch should introduce no breaking changes but please validate your authentication flows post-upgrade.Run existing integration tests or manual smoke tests against a secured endpoint to ensure the new patch release does not affect token validation.
12-12
: Upgrade Azure AppConfiguration AspNetCore package
Microsoft.Azure.AppConfiguration.AspNetCore
updated from 8.1.2 to 8.2.0. Confirm that your configuration refresh and feature-flag behaviors remain unchanged after this bump.A quick manual or automated check on
builder.Configuration.AddAzureAppConfiguration()
would ensure no behavioral drift.src/Digdir.Domain.Dialogporten.WebApi/Digdir.Domain.Dialogporten.WebApi.csproj (2)
12-12
: Upgrade Azure AppConfiguration AspNetCore package
The version is bumped from 8.1.2 to 8.2.0. Ensure that startup-time configuration loading and feature management continue to work as expected.
16-18
: Bump ASP.NET Core packages to 9.0.5
Microsoft.AspNetCore.Authentication.JwtBearer
,Microsoft.AspNetCore.Mvc.NewtonsoftJson
, andMicrosoft.AspNetCore.OpenApi
have been upgraded to 9.0.5. These patch releases should be backward-compatible; please run your API contracts and Swagger generation scenarios to confirm.Execute your end-to-end API tests or regenerate the OpenAPI spec to verify no regressions.
src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj (3)
9-12
: Upgrade caching, user secrets, and Http.Polly packages
References forMicrosoft.Extensions.Caching.StackExchangeRedis
,Configuration.UserSecrets
, andHttp.Polly
have been bumped to 9.0.5. No API surface changes are expected, but ensure your resilience policies still behave correctly.Consider running a brief load-test or fault-injection test to validate your retry policies.
15-15
: Upgrade EF Core Tools to 9.0.5
Microsoft.EntityFrameworkCore.Tools
has been updated to 9.0.5 with PrivateAssets and IncludeAssets configured. Confirm your migrations and tooling remain functional.
20-22
: Upgrade HealthChecks and Hosting.Abstractions
Microsoft.Extensions.Diagnostics.HealthChecks
,Diagnostics.HealthChecks.EntityFrameworkCore
, andHosting.Abstractions
are now at 9.0.5. Please verify that your health check endpoints and EF health probes report correctly after the upgrade.Run
dotnet healthchecks-ui
or your equivalent endpoint to confirm.
No description provided.