8000 Refactor/rename PlaceBet component · Issue #38 · AndreMiras/etheroll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

Refactor/rename PlaceBet component #38

Closed
AndreMiras opened this issue Dec 15, 2018 · 1 comment
Closed

Refactor/rename PlaceBet component #38

AndreMiras opened this issue Dec 15, 2018 · 1 comment
Assignees
@AndreMiras
Labels
enhancement New feature or request

Comments

@AndreMiras
Copy link
Owner

The component PlaceBet has too much logic, it should be broken down to sub-components and utils files.
Also it should be renamed to e.g. RollUnder.
The idea is we will soon have other games like the coin flip #11 and we would like to reuse/share code as much as possible between the two.
@AndreMiras AndreMiras added the enhancement New feature or request label Dec 15, 2018
@AndreMiras AndreMiras self-assigned this Dec 15, 2018
AndreMiras added a commit that referenced this issue Dec 15, 2018
@AndreMiras
Rename RollUnder -> RollUnderInfo, refs #38
13733ca
AndreMiras added a commit that referenced this issue Dec 15, 2018
@AndreMiras
Rename PlaceBet -> RollUnder, refs #38
1c96270
@AndreMiras
Copy link
Owner Author

Fixed in recent changeset, PlaceBet was renamed RollUnder and we now have a base class called BaseGame

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndreMiras AndreMiras

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreMiras
0