switch to OpenCV4 #186
Merged
switch to OpenCV4 #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxmerkt
reviewed
Dec 15, 2021
There was a problem hiding this comment.
This would be correct on Ubuntu 20.04, and hence I am in favour of this change. However, I don't know when/in which distros OpenCV4 is the default OpenCV / when it will be installed in this directory (e.g. we recently ran into issues on Nvidia devkits that had non-standard OpenCV paths). That said, since most users will likely use CMake this should be fine.
|
I also think this makes sense. We should bump the minor minor version number after this change though |
mkrogius
approved these changes
Dec 17, 2021
|
I incremented the minor version 3.1 -> 3.2. Please tag this version after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the Makefile to use OpenCV 4 and also sets the include path correctly via
pkg-config --cflags.