8000 `b611` test case is broken · Issue #531 · B-Lang-org/bsc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

b611 test case is broken #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RyanGlScott opened this issue Jan 6, 2023 · 0 comments · Fixed by #532 or #533
Closed

b611 test case is broken #531

RyanGlScott opened this issue Jan 6, 2023 · 0 comments · Fixed by #532 or #533

Comments

@RyanGlScott
Copy link
Contributor

The bsc.bugs/bluespec_inc/611 test case (which requires setting DO_INTERNAL_CHECKS=1 to run) is currently broken:

$ make localcheck
cleaning /home/rscott/Documents/Hacking/Haskell/bsc/testsuite/bsc.bugs/bluespec_inc/b611
MAKEFLAGS= BSCTEST=1 BSC=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/bsc BSC_OPTIONS="" BSDIR=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/lib DUMPBO=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/dumpbo BSC2BSV=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/bsc2bsv BSV2BSC=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/bsv2bsc VCDCHECK=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/vcdcheck SHOWRULES=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/showrules BLUESPECDIR=/home/rscott/Documents/Hacking/Haskell/bsc/inst/lib BSC_VERILOG_SIM=iverilog TEST_CONFIG_DIR=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/config BLUETCL=/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/../inst/bin/bluetcl OSTYPE=Linux LC_ALL=C SYSTEMC_INC= SYSTEMC_LIB= PATH="/home/rscott/Documents/Hacking/Haskell/bsc/inst/lib/../bin:/home/rscott/.ghcup/tmp/ghcup-ghc-8.10.7:/home/rscott/.opam/4.14.0-coq-8.15.2/bin:/home/rscott/.ghcup/bin:/home/rscott/.cargo/bin:/home/rscott/.poetry/bin:/home/rscott/.elan/bin:/home/rscott/Software/bsc-2022.01/bin:/home/rscott/.cabal/bin:/opt/cabal/3.4/bin:/home/rscott/.idris2/bin:/opt/ghc/8.10.4/bin:/home/rscott/Software/armv7m-linux-musleabi-cross/bin:/opt/spark/bin:/opt/spark/sbin:/home/rscott/Software/what4-solvers:/home/rscott/.local/bin:/home/rscott/bin:/home/rscott/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/home/rscott/.local/bin:/home/rscott/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin"  runtest --tool "" --objdir . --status  *.exp
WARNING: Couldn't find tool init file
Test run by rscott on Fri Jan  6 09:46:02 2023
Native configuration is x86_64-pc-linux-gnu

                ===  tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using ./../../../config/unix.exp as tool-and-target-specific interface file.
testconfig dir is: /home/rscott/Documents/Hacking/Haskell/bsc/testsuite/config
Sourcing: /home/rscott/Documents/Hacking/Haskell/bsc/testsuite/config/verilog.tcl
testconfig dir is: /home/rscott/Documents/Hacking/Haskell/bsc/testsuite/config
Sourcing: /home/rscott/Documents/Hacking/Haskell/bsc/testsuite/config/bluetcl.tcl
Running ./b611.exp ...
ERROR: tcl error sourcing ./b611.exp.
ERROR: extra characters after close-quote
    while executing
"set status [exec_with_log "bsc2bsv"$"
    (procedure "bsc2bsv" line 14)
    invoked from within
"bsc2bsv $source"
    (procedure "run_bsc2bsv" line 11)
    invoked from within
"run_bsc2bsv Bug611.bs"
    (file "./b611.exp" line 1)
    invoked from within
"source ./b611.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ./b611.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

       === Test Distribution Summary === 
   run_bsc2bsv                              --     1
Total:                                      --     1

                === Timing by Category ===

  WALLCLOCK sec        CPU sec      SYSTEM sec   #calls  CATEGORY
     0.0 (100%)      0.0 (100%)      0.0 (100%)       0  TOTAL

                ===  Summary ===

make: *** [/home/rscott/Documents/Hacking/Haskell/bsc/testsuite/suitemake.mk:116: localcheck] Error 2

The culprit is a syntax error here:

bsc/testsuite/config/unix.exp

Line 1080 in de3a575

set status [exec_with_log "bsc2bsv"$cmd 2]

There should be a space between "bsc2bsv" and $cmd. This was not caught by CI since the CI does not enable DO_INTERNAL_CHECKS—see #530.
This was referenced Jan 6, 2023
Open
Closed
RyanGlScott added a commit to RyanGlScott/bsc that referenced this issue Jan 6, 2023
@RyanGlScott
Testsuite: Fix syntax error in bsc2bsv command
b287fcb 
There was a missing space in the command that invokes `bsc2bsv`, which resulted
in a syntax error when trying to use it.

With this patch applied, I am able to run the `b611` test case successfully.

Fixes B-Lang-org#531.
This was referenced Jan 6, 2023
Merged
Merged
quark17 pushed a commit that referenced this issue Jan 10, 2023
@RyanGlScott @quark17
Testsuite: Fix syntax error in bsc2bsv command
201eef8 
There was a missing space in the command that invokes `bsc2bsv`, which resulted
in a syntax error when trying to use it.

With this patch applied, I am able to run the `b611` test case successfully.

Fixes #531.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@RyanGlScott
0