8000 Write/create/truncate prototxt when saving to fix #341 by shelhamer · Pull Request #417 · BVLC/caffe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Write/create/truncate prototxt when saving to fix #341 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2014
Merged

Write/create/truncate prototxt when saving to fix #341 #417

merged 2 commits into from
May 14, 2014

Conversation

shelhamer
Copy link
Member

Create the output file if it doesn't exist or overwrite it if it exists with content when saving a prototxt and set permissions to owner all and group + other read.

One could overwrite a prototxt this way, but such is the peril of saving files.

This will cherry-picked to master or a new release will be made soon enough to fix the problem there.

shelhamer added 2 commits May 14, 2014 12:28
@shelhamer
Write/create/truncate prototxt when saving to fix BVLC#341
f436cb2 
WriteProtoToTextFile now saves the prototxt whether or not the file
already exists and sets the permissions to owner read/write and group +
other read.

Thanks @beam2d and @chyh1990 for pointing out the open modes bug.
@shelhamer
fix workaround in net prototxt upgrade
8000
a894796
@shelhamer shelhamer mentioned this pull request May 14, 2014
Closed
@jeffdonahue
Copy link
Contributor

Cool, thanks Evan!

jeffdonahue added a commit that referenced this pull request May 14, 2014
@jeffdonahue
Merge pull request #417 from shelhamer/create-and-write-proto
91c59d7 
Write/create/truncate prototxt when saving to fix #341
@jeffdonahue jeffdonahue merged commit 91c59d7 into BVLC:dev May 14, 2014
@shelhamer shelhamer deleted the create-and-write-proto branch May 15, 2014 06:55
This was referenced May 15, 2014
Closed
Merged
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
@jeffdonahue
Merge pull request BVLC#417 from shelhamer/create-and-write-proto
7b5dea1 
Write/create/truncate prototxt when saving to fix BVLC#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shelhamer @jeffdonahue
0