8000 fix for layer-type-str: loss_param in V1LayerParameter by jeffdonahue · Pull Request #1836 · BVLC/caffe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix for layer-type-str: loss_param in V1LayerParameter #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2015
Merged

fix for layer-type-str: loss_param in V1LayerParameter #1836

merged 1 commit into from
Feb 6, 2015

Conversation

jeffdonahue
Copy link
Contributor

Fixes upgrade bug I introduced in #1694: I forgot to add loss_param to V1LayerParameter after it was added by @longjon and I rebased on his work. Will merge this once Travis passes (and I go check caffe.proto again to make sure nothing else is missing..)

@jeffdonahue jeffdonahue changed the title fix for layer-type-str: loss_param should have been included in fix for layer-type-str: loss_param in V1LayerParameter Feb 6, 2015
@jeffdonahue
fix for layer-type-str: loss_param and DECONVOLUTION type should have
6a22697 
been included in V1LayerParameter, get upgraded
@jeffdonahue jeffdonahue force-pushed the loss-param-upgrade-fix branch from cd857ae to 6a22697 Compare February 6, 2015 03:53
@jeffdonahue
Copy link
Contributor Author

Oops, I'd forgotten deconvolution layer as well -- now fixed too. Sorry for temporarily breaking all of your recent improvements @longjon... I think the V1LayerParameter now matches exactly what LayerParameter was before #1694.

@jeffdonahue
Copy link
Contributor Author

Hmmm... Travis is failing due to (hopefully temporary) issues downloading Ubuntu updates from PPA:

Failed to fetch http://ppa.launchpad.net/tuleu/precise-backports/ubuntu/pool/main/g/gflags/libgflags2_2.0-1.1ubuntu1~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:
Failed to fetch http://ppa.launchpad.net/tuleu/precise-backports/ubuntu/pool/main/g/google-glog/libgoogle-glog0_0.3.3-1~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:
Failed to fetch http://ppa.launchpad.net/tuleu/precise-backports/ubuntu/pool/main/g/gflags/libgflags-dev_2.0-1.1ubuntu1~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:
Failed to fetch http://ppa.launchpad.net/tuleu/precise-backports/ubuntu/pool/main/g/google-glog/libgoogle-glog-dev_0.3.3-1~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command "sudo -E $SCRIPTS/travis_install.sh" failed and exited with 100 during .

I've built this and done make runtest, so I'll merge without Travis's blessing since this is a bugfix (and the bug breaks things that worked prior to #1694).

jeffdonahue added a commit that referenced this pull request Feb 6, 2015
@jeffdonahue
Merge pull request #1836 from jeffdonahue/loss-param-upgrade-fix
336ef5a 
fix for layer-type-str: loss_param in V1LayerParameter
@jeffdonahue jeffdonahue merged commit 336ef5a into BVLC:dev Feb 6, 2015
@jeffdonahue jeffdonahue deleted the loss-param-upgrade-fix branch February 6, 2015 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffdonahue
0