Fix im2col nonsquare bug (#284) #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expose bug (GPU tests now fail due to the bug)
|
Thanks @jeffdonahue and thanks for the catch @kmatzen. |
shelhamer
added a commit
that referenced
this pull request
Apr 8, 2014
Fix im2col nonsquare bug (#284)
|
Fix commit cherry-picked to master in 5528f5e as suggested. |
Merged
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Fix im2col nonsquare bug (BVLC#284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 58fe797 modifies the tests in test_convolution_layer.cpp to expose the im2col GPU bounds checking bug for non-square inputs identified by @kmatzen (#284). Commit 1fa5ae2 fixes the bug and makes the tests pass. The change to im2col.cu can be cherry-picked into master but the tests won't work on master without modifications (due to using convolution_param()).