Migrate docker-hub to ECR using git-action #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
martinkersner
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request (PR) is about migrating the repository from Docker Hub to AWS ECR. The reason for this change is that Docker Hub has a limitation for upload after a certain megabyte or call, which slows down the upload speed significantly. Therefore, I decided to migrate the repository to AWS ECR.
To connect to AWS ECR, I do not store any AWS secrets on Git-Action-Secrets. Instead, I use AWS web-identity to log in to ECR.
I have made the repository in ECR public for now. However, I plan to write a description about the organization later.
This PR is only triggered when you merge into the 'Master' branch containing each service changed. After merging, this will create using docker-compose in 'src/'. These images will then be pushed to ECR.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment