8000 fix git actions deprecated warning by jo-bisonai · Pull Request #497 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix git actions deprecated warning #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2023
Merged

fix git actions deprecated warning #497

merged 5 commits into from
Apr 10, 2023

Conversation

jo-bisonai
Copy link
Member

Description

There is currently an issue with the aws credentials in Git Actions not being updated after switching from SDK version 2 to 3. Although version 2 is still working, it is in maintenance mode, so it's unclear whether it will continue to work properly. However, the credentials are still being received correctly when pushing to the repository in myside.
It may be helpful for you to try again to see this was temporary or not.

Additionally, the warning (deprecated) that was raised is unrelated to the credentials issue but fixed with this.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@jo-bisonai jo-bisonai requested a review from martinkersner April 9, 2023 23:33
@jo-bisonai jo-bisonai self-assigned this Apr 9, 2023
@jo-bisonai jo-bisonai linked an issue Apr 9, 2023 that may be closed by this pull request
Fix git actions for version #496
Closed
martinkersner
martinkersner approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member
@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit c586451 into master Apr 10, 2023
@martinkersner martinkersner deleted the i-496/fix-git-actions-for-version branch April 10, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

Assignees

@jo-bisonai jo-bisonai

Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix git actions for version
2 participants
@jo-bisonai @martinkersner
0