8000 Aggregator related updates by martinkersner · Pull Request #593 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Aggregator related updates #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 3, 2023
Merged

Aggregator related updates #593

merged 14 commits into from
May 3, 2023

Conversation

martinkersner
Copy link
Member
@martinkersner martinkersner commented May 2, 2023 •
edited
Loading

Description

This PR slightly changes and improve Aggregator contract code and add more tests.

  • Made MAX_ORACLE_COUNT public
  • Replaced some require with revert
  • Added auxiliary function currentRoundStartedAt that will be used by off-chain oracle to compute synchronized delay
  • Added comments to not so obvious functions and code statements
  • Added more Aggregator tests

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this May 2, 2023
@martinkersner martinkersner linked an issue May 2, 2023 that may be closed by this pull request
acceptingSubmissions seems wrong in Aggregator #135
Closed
@martinkersner martinkersner mentioned this pull request May 2, 2023
Closed
@martinkersner martinkersner linked an issue May 3, 2023 that may be closed by this pull request
Use of updateTimedOutRoundInfo seems wrong #136
Closed
@martinkersner martinkersner marked this pull request as ready for review May 3, 2023 02:30
@martinkersner martinkersner merged commit ad1970f into master May 3, 2023
@martinkersner martinkersner deleted the i-591/feat/aggregator branch May 3, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment< 6AA9 /a>
Reviewers

@bayram98 bayram98 Awaiting requested review from bayram98

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of updateTimedOutRoundInfo seems wrong acceptingSubmissions seems wrong in Aggregator
1 participant
@martinkersner
0