10000 Feat detail page tab component by joeybisonai · Pull Request #625 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat detail page tab component #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 22, 2023

Conversation

joeybisonai
Copy link
Member
@joeybisonai joeybisonai commented May 17, 2023

Description

스크린샷 2023-05-22 오전 9 50 03

  1. Connect data to the detail table component.
  2. Implement routing for the component.
  3. Add a status tab.
    //TODO
    each table is receiving a large amount of data that I'm not familiar with
    so discuss with jo where each data should be displayed.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.

@joeybisonai joeybisonai self-assigned this May 17, 2023
@joeybisonai joeybisonai linked an issue May 17, 2023 that may be closed by this pull request
@joeybisonai joeybisonai marked this pull request as ready for review May 22, 2023 01:53
Copy link
Member
@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joeybisonai joeybisonai merged commit e3735d7 into master May 22, 2023
@joeybisonai joeybisonai deleted the i-623/feat/detail-page-tab-component branch May 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detail page tab component
2 participants
0