interface for Subscription #71
Conversation
Co-authored-by: Martin Kersner <martin@bisonai.com>
…sonai-CIC/ICN into I-67/feat/Subscrition_payment
| @@ -0,0 +1,315 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.16; | |||
| import "openzeppelin-solidity/contracts/access/AccessControlEnumerable.sol"; | |||
There was a problem hiding this comment.
I think there is some convention where people prepend @ in front of packages that are imported from node-modules. It can help us to understand project structure from the get-go.
| ) ConfirmedOwner(msg.sender) { | ||
| // BLOCKHASH_STORE = BlockhashStoreInterface(blockhashStore); | ||
| // set prepayment | ||
| Prepayment=prepayment; |
There was a problem hiding this comment.
I did not find any function which allow us to update the prepayment. It would be nice to be able to change it if necessary.
There was a problem hiding this comment.
you mean when we update the implementations of prepayment but with the same interface?
There was a problem hiding this comment.
Yes. In case there is some implementation issue but not problem with interface. Do you think it could be less secure if we offer the change of payment?
There was a problem hiding this comment.
hmm!. let me think about it more. there could be a lot of scenarios
| @@ -0,0 +1,34 @@ | |||
| import pkg from 'hardhat' | |||
There was a problem hiding this comment.
Soon, we will be using exclusively hardhat-deploy which will require a little bit different (but MUCH better!) style of deployment and testing so I am not going to comment on this file.
contracts/test/PrepaymentTest.cjs
Outdated
| const { expect } = require("chai"); | ||
| const { loadFixture } = require("@nomicfoundation/hardhat-network-helpers"); | ||
|
|
||
| const abi = [ |
There was a problem hiding this comment.
With hardhat-deploy we want have to do these crazy imports. Coming soon!
…sonai-CIC/ICN into I-67/feat/Subscrition_payment
Co-authored-by: Martin Kersner <martin@bisonai.com>
Co-authored-by: Martin Kersner <martin@bisonai.com>
…sonai-CIC/ICN into I-67/feat/Subscrition_payment
Co-authored-by: Martin Kersner <martin@bisonai.com>
Co-authored-by: Martin Kersner <martin@bisonai.com>
Co-authored-by: Martin Kersner <martin@bisonai.com>
|
This PR is somehow broken. Closing it for
|
New files: