8000 Check for validity of `keyHash` in VRF request by martinkersner · Pull Request #155 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check for validity of keyHash in VRF request #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2023
Merged

Check for validity of keyHash in VRF request #155

merged 3 commits into from
Jan 18, 2023

Conversation

martinkersner
Copy link
Member
@martinkersner martinkersner commented Jan 18, 2023 •
edited
Loading

This PR consists of VRFCoordinator update. Previously, we have not made any check for what kind of keyHash is submitted during request for VRF. It could lead to submitting an invalid key hash, and consequently not processing request. From now, we revert request if key hash has not been registered (registerProvingKey) inside of VRFCoordinator.

Tests

npx hardhat test test/v0.1/VRF.test.ts

@martinkersner martinkersner linked an issue Jan 18, 2023 that may be closed by this pull request
Don't allow to request for keyHash of deregistered oracle #119
Closed
@martinkersner martinkersner self-assigned this Jan 18, 2023
@martinkersner martinkersner marked this pull request as ready for review January 18, 2023 05:59
@martinkersner martinkersner merged commit 9cc8795 into master Jan 18, 2023
@martinkersner martinkersner deleted the i-119/feat/dont-allow-to-request-vrf-from-unregistered-oracle branch January 18, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

@jo-bisonai jo-bisonai Awaiting requested review from jo-bisonai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow to request for keyHash of deregistered oracle
1 participant
@martinkersner
0