8000 add `BTC/USD`, `ETH/USD` data feeds by bayram98 · Pull Request #279 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add BTC/USD, ETH/USD data feeds #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2023
Merged

add BTC/USD, ETH/USD data feeds #279

merged 3 commits into from
Feb 15, 2023

Conversation

bayram98
Copy link
Contributor
@bayram98 bayram98 commented Feb 15, 2023 •
edited
Loading

Description

With this PR I added BTC/USD and ETH/USD new data feed adapters and aggregatores.
Currently, I used 6 different data source to collect data feeds and suppose to work for each second.
For more information: https://www.notion.so/bisonai/Price-Feed-API-05db92bde04a4db1ac65dc2101887009

Important

With current version, getting price feed fail, if there is any problem with of the data sources.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.

Deployment

  • Should publish Docker image

@bayram98 bayram98 self-assigned this Feb 15, 2023
@bayram98 bayram98 linked an issue Feb 15, 2023 that may be closed by this pull request
Build data feeds #68
Closed
@bayram98 bayram98 removed the request for review from jo-bisonai February 15, 2023 04:54
@bayram98 bayram98 marked this pull request as ready for review February 15, 2023 04:55
martinkersner
martinkersner approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member
@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit 8956f57 into master Feb 15, 2023
@martinkersner martinkersner deleted the i-68/feat/build-data-feeds branch February 15, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@bayram98 bayram98

Labels
off-chain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build data feeds
2 participants
@bayram98 @martinkersner
0