small optimization for fsfinder #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds because of optimization (arrays were used only to check the occurrence of an element)
|
Output of the benchmark run and here's the benchmark against the main branch finder: Some pretty clear improvements. Thanks @SkobelkinYaroslav ! |
kehoecj
approved these changes
May 30, 2024
kehoecj
reviewed
Aug 3, 2024
kehoecj
reviewed
Aug 3, 2024
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* changed []string to map[string]struct{} in FileSystemFinder struct fields because of optimization (arrays were used only to check the occurrence of an element)
* Changed field Extensions type in FileType from []string to map[string]struct{}
* added requested changes
* small refactoring of findOne func
* fixd the return value
* get back to trimprefix func
* cleanup
* fsfinder optimization
* i hope it fixed
* removed unnecessary calls to filepath.Abs
* Apply suggestions from code review
---------
Co-authored-by: Yaroslav <=>
Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* changed []string to map[string]struct{} in FileSystemFinder struct fields because of optimization (arrays were used only to check the occurrence of an element)
* Changed field Extensions type in FileType from []string to map[string]struct{}
* added requested changes
* small refactoring of findOne func
* fixd the return value
* get back to trimprefix func
* cleanup
* fsfinder optimization
* i hope it fixed
* removed unnecessary calls to filepath.Abs
* Apply suggestions from code review
---------
Co-authored-by: Yaroslav <=>
Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some optimization and added benchmark to test it