More fixes #98

Altair-Alpha · 2022-04-10T15:58:17Z

Vector2 class is missing a operator[] as Vector3 and Vector4 does. Also there're 3 typos in the comment.
In scene_manager:
https://github.com/BoomingTech/Pilot/blob/5de12a37d1709ced2d2be324ad5f7a88727bfb9b/engine/source/runtime/function/scene/scene_manager.h#L38
this function declares its parameter as const &&(seems strange), I suppose it should be either const & or &&?

https://github.com/BoomingTech/Pilot/blob/5de12a37d1709ced2d2be324ad5f7a88727bfb9b/engine/source/runtime/function/scene/scene_manager.cpp#L678
The release function for mesh, material and skeleton binding use auto to get the element from a std::deque, which is a copy. Maybe it's better to use a reference. Also renaming the variable handle to skeleton_binding_handle to keep consistent with its counterparts in mesh and material release function. If the team is working on a bigger refactoring of this class, you can ignore this commit:)

Altair-Alpha added 2 commits April 10, 2022 23:19

Implement missing operator[] and fix typos in comments for Vector2 class

141b711

Correct specifier for auto variable

2640d1f

hyv1001 merged commit 3a3fa15 into BoomingTech:main Apr 11, 2022

Altair-Alpha deleted the fixes branch April 11, 2022 04:17

Provide feedback