8000 修复macOS编辑模式抛出的异常 by luxiaodong · Pull Request #352 · BoomingTech/Piccolo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

修复macOS编辑模式抛出的异常 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2022
Merged

修复macOS编辑模式抛出的异常 #352

merged 4 commits into from
Sep 20, 2022

Conversation

luxiaodong
Copy link
Contributor

No description provided.

@luxiaodong luxiaodong closed this Sep 19, 2022
@luxiaodong luxiaodong reopened this Sep 19, 2022
@luxiaodong luxiaodong changed the title Fix spell error 修复macOS编辑模式抛出的异常 Sep 19, 2022
@Ol6rin Ol6rin requested a review from heyx1997 September 19, 2022 09:20
@heyx1997
Copy link
Contributor

非常感谢你的反馈。
该异常的原因是在 command buffer begin 前写入了 debug 用的 label,因此修改为提前调用 vkBeginCommandBuffer。而没有将command buffer 的 usage flag 设置为可重用,仍旧采用默认值,所有的 command 一次性写入。

@heyx1997 heyx1997 merged commit a2a01cc into BoomingTech:main Sep 20, 2022
KaygNas pushed a commit to KaygNas/Piccolo that referenced this pull request Feb 10, 2023
* fix particle system  issue on mac & standardize label usage

Co-authored-by: yingxiang.he <yingxiang.he@boomingtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0