10000 new cc format for msnbc? · Issue #1681 · CCExtractor/ccextractor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new cc format for msnbc? #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
williamj77 opened this issue Apr 3, 2025 · 13 comments
Open

new cc format for msnbc? #1681

williamj77 opened this issue Apr 3, 2025 · 13 comments

Comments

@williamj77
Copy link

Carlos:

Can you take a look at this ts file?

If you remember, you created a custom version of ccextractor for the Hauppuage tv tuner.

There now seems to be periods inserted into the text.

Attached are the files.

You can download the ts file here:

https://www.dropbox.com/scl/fi/4b1y86efag39sjnmm65hs/all_in_with_chris_hayes_20250326_1958.ts?rlkey=tyid6blj5hvsbyhg1mxs9nvr8&st=557jrkq8&dl=0

Again, this is from a Hauppauge tv tuner.

I have experienced issues from a potential hacker.

Sincerely,
William Johnston

ccoutput.zip
@cfsmp3
Copy link
Contributor
cfsmp3 commented Apr 4, 2025

I'm not super involved in the code these days but someone that is currently active will take a look ASAP.

@321david123
Copy link

ccx_encoders_srt.c.zip

Playing with the ccx_encoders_srt.c file I found this "solution" that removes periods in places like the example you showed @williamj77 . However, it also strips periods from the ends of all sentences, which affects expected output in other cases. Thats why I'm not making a pull request because it can affect other use cases. Still, it might help someone else refine the logic

Image

@williamj77
Copy link
Author
williamj77 commented Apr 24, 2025 via email

@321david123
Copy link

It does work @williamj77 here's the complete file:

output.srt.zip

If you want to try it by yourself on other files, you just have to replace the encoder with the one in my last comment and follow the standard build instructions. Hope this helps!.

@cfsmp3
Copy link
Contributor
cfsmp3 commented Apr 25, 2025

If the problem is with the input, we shouldn't do anything. Periods can be removed by a post script if needed.

If the problem is that we're not processing the input correctly, then we should figure out what's going on. But if players such as VLC display the periods, then they're just there and there's nothing for us to fix.

@williamj77
Copy link
Author
williamj77 commented Apr 25, 2025 via email

@williamj77
Copy link
Author
williamj77 commented Apr 28, 2025 via email

@vatsalkeshav
Copy link
Contributor
vatsalkeshav commented Apr 28, 2025 via email

@williamj77
Copy link
Author
williamj77 commented Apr 28, 2025 via email

@vatsalkeshav
Copy link
Contributor
vatsalkeshav commented Apr 29, 2025 via email •
edited
Loading

@williamj77
Copy link
Author
williamj77 commented Apr 29, 2025 via email

@steel-bucket
Copy link
Contributor
steel-bucket commented Apr 29, 2025 •
edited
Loading

Hi, if you're using windows, then you could easily just run the docker build for testing out different files.
Here's the instructions to run the main branch, you can just replace the \path\to\video\ with the location of your file and then copy and paste into terminal.
For testing another file, just run docker run --rm -v $(pwd):$(pwd) -w "$(pwd)" --user $(id -u):$(id -g) ccextractor:latest <YOURFILE> --hauppauge -o output.srt

git clone https://github.com/CCExtractor/ccextractor.git
cd ccextractor\docker
docker build --platform linux/amd64 -t ccextractor .
copy \path\to\video\all_in_with_chris_hayes_20250326_1958.ts .
docker run --rm -v $(pwd):$(pwd) -w "$(pwd)" --user $(id -u):$(id -g) ccextractor:latest all_in_with_chris_hayes_20250326_1958.ts --hauppauge -o output.srt

If you wanted to run it with 321david123's new SRT encoder, I've made a branch for the updated code(credit for the code goes to 321david123)

git clone https://github.com/steel-bucket/ccextractor/ -b 321david123-FIX
cd ccextractor\docker
docker build --platform linux/amd64 -t ccextractor .
copy \path\to\video\all_in_with_chris_hayes_20250326_1958.ts .
docker run --rm -v $(pwd):$(pwd) -w "$(pwd)" --user $(id -u):$(id -g) ccextractor:latest all_in_with_chris_hayes_20250326_1958.ts --hauppauge -o output.srt

This is for testing files, if there's need for exe, we can prepare one.

@williamj77
Copy link
Author
williamj77 commented Apr 30, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cfsmp3 @williamj77 @steel-bucket @321david123 @vatsalkeshav
0