8000 Fix of docs and some edge-cases on @APIClient.requires decorated methods by psrok1 · Pull Request #79 · CERT-Polska/mwdblib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix of docs and some edge-cases on @APIClient.requires decorated methods #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

psrok1
Copy link
Member
@psrok1 psrok1 commented Jun 23, 2022
  • Methods exposed by VersionDependentMethod.__get__ were not correctly wrapped, so they didn't appear in documentation
  • mwdb name used in handler isn't correct, MWDBObject is also possible when its methods are decorated using that wrapper
  • @<method>.fallback should return the original method instead of main method

closes #77

@psrok1 psrok1 force-pushed the fix/requires-decorator branch from d5e48b7 to fa97ad7 Compare June 23, 2022 15:02
@psrok1 psrok1 force-pushed the fix/requires-decorator branch from fa97ad7 to ca16cd6 Compare June 23, 2022 15:16
@psrok1 psrok1 merged commit d2e9fb3 into master Jul 7, 2022
@psrok1 psrok1 deleted the fix/requires-decorator branch July 7, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Methods decorated with APIClient.requires are missing in documentation
1 participant
0