8000 Fix type hints _PassWorkingDb by rdesparbes · Pull Request #301 · CEXT-Dan/PyRx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix type hints _PassWorkingDb #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

Fix type hints _PassWorkingDb #301

merged 4 commits into from
Apr 29, 2025

Conversation

rdesparbes
Copy link
Collaborator
@rdesparbes rdesparbes commented Apr 28, 2025 •
edited
Loading

This pull request:

  • Fixes type hints that were not precise enough for VSCode (Solves this thread)
  • Fixes a regression introduced in Add pytest to CI #299 where lauching RUNTESTS in the CAD only launched the tests for the CI
  • Fixes tests that started failing after adding docstrings to the AbstractViewTableRecord.__init__ method.

@rdesparbes rdesparbes requested a review from gswifort April 28, 2025 20:43
gswifort
gswifort approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator
@gswifort gswifort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok

@CEXT-Dan CEXT-Dan merged commit 322512c into main Apr 29, 2025
3 checks passed
@gswifort gswifort deleted the fix-type-hints-pass_working_db branch May 17, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gswifort gswifort gswifort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdesparbes @gswifort @CEXT-Dan
0