[#317] remove load_repl in user config, add ignore extra values #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ignore extra values
There was a problem hiding this comment.
Pull Request Overview
This PR removes the load_repl configuration option and associated tests while adding support for ignoring extra values in user configuration.
- Removed references to load_repl from tests and configuration files
- Updated the model configuration to ignore extra fields
- Adjusted the host initialization to unconditionally import the REPL module
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_config.py | Removed tests and assertions for load_repl and added tests for extra values |
| pyrx/pyrx.toml | Removed the load_repl setting from the configuration file |
| pyrx/config.py | Removed the load_repl property and updated the model_config to ignore extra fields |
| pyrx/_host_init.py | Removed conditional REPL loading based on load_repl and now always imports the module |
Comments suppressed due to low confidence (2)
tests/test_config.py:22
- [nitpick] Consider revising the docstring to improve clarity and grammatical agreement (e.g., 'ensure PYRX_DISABLE_ONLOAD is unset').
'''Setup method to ensure PYRX_DISABLE_ONLOAD are unset.'''
pyrx/_host_init.py:104
- The conditional loading for the REPL module based on the 'load_repl' setting was removed and is now imported unconditionally; please confirm that this change in behavior is intended and properly documented.
import pyrx.repl.repl_cmds # noqa: F401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.