Use valid dates when unsaling products #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE has historically used a wide variety of empty-ish values in
products.start_dateandproducts.end_datethat would be permissively accepted by older versions and configurations of MySQL. Newer out-of-the-box strictness settings are less tolerant of this kind of thing. Submitting cleaner data is a better solution than asking users to dial-down strictness settings.This approach uniformly uses
1900-01-01for dates when taking an item off sale. There's probably a fair argument forNULLbut1900-01-01is one of the values that's been used for this purpose in the past.