8000 CATROID-1016 Show survey always in a WebView by dandrawes · Pull Request #4078 · Catrobat/Catroid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CATROID-1016 Show survey always in a WebView #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2021
Merged

CATROID-1016 Show survey always in a WebView #4078

merged 3 commits into from
Apr 9, 2021

Conversation

dandrawes
Copy link
Contributor

https://jira.catrob.at/browse/CATROID-1016

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

mstoeg
mstoeg approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor
@mstoeg mstoeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@wslany wslany added the WIP Work in progress label Apr 6, 2021
@wslany wslany merged commit 4e34655 into Catrobat:develop Apr 9, 2021
@wslany
Copy link
Member
wslany commented Apr 9, 2021

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoeg mstoeg mstoeg approved these changes

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandrawes @wslany @mstoeg
0