8000 CATROID-235 Start running stitch with length 10 by adnaribo · Pull Request #3461 · Catrobat/Catroid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CATROID-235 Start running stitch with length 10 #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

CATROID-235 Start running stitch with length 10 #3461

merged 1 commit into from
Feb 10, 2020

Conversation

adnaribo
Copy link
Contributor
@adnaribo adnaribo commented Feb 7, 2020

No description provided.

DinosaurierRex
DinosaurierRex requested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor
@DinosaurierRex DinosaurierRex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

catroid/src/main/java/org/catrobat/catroid/content/actions/RunningStitchAction.java Outdated
protected void update(float delta) {
int lengthInterpretation;
try {
lengthInterpretation = length == null ? 0 : length.interpretInteger(sprite);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply same changes as requested in first review here.

DinosaurierRex
DinosaurierRex approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor
@DinosaurierRex DinosaurierRex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslany wslany merged commit 54d49ef into Catrobat:develop Feb 10, 2020
@wslany
Copy link
Member
wslany commented Feb 10, 2020 •
edited
Loading

Thanks!! :)

Koell pushed a commit to Koell/Catroid that referenced this pull request Feb 28, 2020
@wslany
Merge pull request Catrobat#3461 from adnaribo/CATROID-235
c26be54 
CATROID-235 Start running stitch with length 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinosaurierRex DinosaurierRex DinosaurierRex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adnaribo @wslany @DinosaurierRex @shellp
0