8000 CATROID-879 Change formula editor input field by juliajulie95 · Pull Request #3926 · Catrobat/Catroid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CATROID-879 Change formula editor input field #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

CATROID-879 Change formula editor input field #3926

merged 1 commit into from
Jan 8, 2021

Conversation

juliajulie95
Copy link
Contributor

https://jira.catrob.at/browse/CATROID-879
Minor design change
Screenshot_1609859864

Because the formula editor is very bright compared to the app overall, the background of the formula editor was deleted.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Walcho1125
Walcho1125 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor
@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wslany wslany merged commit 580c553 into Catrobat:develop Jan 8, 2021
@wslany
Copy link
Member
wslany commented Jan 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
< 574E span class="css-truncate">

@Walcho1125 Walcho1125 Walcho1125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliajulie95 @wslany @Walcho1125
0