8000 Fix HTML for menu count badges by respencer · Pull Request #6954 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix HTML for menu count badges #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix HTML for menu count badges #6954

merged 2 commits into from
Apr 23, 2024

Conversation

respencer
Copy link
Contributor

Courtesy of @DAcodedBEAT in Gitter chat.

Description & Issue number it closes

Closes #6953

Screenshots (if appropriate)

See linked issue.

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner April 22, 2024 19:42
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team April 22, 2024 19:42
grayeul
grayeul reviewed Apr 22, 2024
View reviewed changes
@respencer respencer requested a review from DAcodedBEAT April 23, 2024 14:48
@DawoudIO DawoudIO added this to the vNext (5.8.0) milestone Apr 23, 2024
@DawoudIO DawoudIO merged commit 9391eee into ChurchCRM:master Apr 23, 2024
3 checks passed
@respencer respencer deleted the calendar-anniversary-count-badge-fix branch April 23, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayeul grayeul grayeul left review comments

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

@DAcodedBEAT DAcodedBEAT Awaiting requested review from DAcodedBEAT

Assignees
No one assigned
Labels
bug UI
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Bug: Calendar Anniversary count badge hiding
4 participants
@respencer @grayeul @DAcodedBEAT @DawoudIO
0