8000 Edit for consistant menu rendering by respencer · Pull Request #6962 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Edit for consistant menu rendering #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

Edit for consistant menu rendering #6962

merged 1 commit into from
Apr 25, 2024

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

No issue number for this, let me know if you need one?

This PR makes the menu styling consistent (some entries were bold and some not). Now none are bold.
Also fixed alignment of remaining counters and left-angle icons.

Screenshots (if appropriate)

Screen Shot 2024-04-25 at 20 30 05

Screen Shot 2024-04-25 at 20 29 26

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in h 8000 ard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner April 25, 2024 19:00
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team April 25, 2024 19:00
@grayeul
Copy link
Contributor
grayeul commented Apr 25, 2024

LGTM

grayeul
grayeul approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor
@grayeul grayeul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed seeing the actual 'review' button... so adding comment here, that this change looks fine to me.

@DAcodedBEAT DAcodedBEAT added UI php Pull requests that update Php code labels Apr 25, 2024
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.8.0) milestone Apr 25, 2024
@DawoudIO
Copy link
Contributor

I tested it, looks good, thanks for this

@DawoudIO DawoudIO merged commit 4a56dcd into ChurchCRM:master Apr 25, 2024
@respencer respencer deleted the further-menu-tweaks branch April 26, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawoudIO DawoudIO DawoudIO approved these changes

@grayeul grayeul grayeul approved these changes

@DAcodedBEAT DAcodedBEAT DAcodedBEAT approved these changes

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
php Pull requests that update Php code UI
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@respencer @grayeul @DawoudIO @DAcodedBEAT
0