8000 Instance badge should be a navbar class; also documentation · Issue #5499 · Clinical-Genomics/scout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Instance badge should be a navbar class; also documentation #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnil opened this issue May 27, 2025 · 1 comment · Fixed by #5500
Closed

Instance badge should be a navbar class; also documentation #5499

dnil opened this issue May 27, 2025 · 1 comment · Fixed by #5500
Assignees
@dnil
Labels
docs QualityOfLife

Comments

@dnil
Copy link
Collaborator
dnil commented May 27, 2025

From color testing, the page layout is currently slightly confused, with the navbar being a little longer than before with the new instance label. Chrome does a better job than safari here.
Image
Image

Perhaps set the badge to .navbar-text or just make it part of the brand?

We should also document the new config variables.
@dnil dnil self-assigned this May 27, 2025
dnil added a commit that referenced this issue May 27, 2025
@dnil
Fix #5499 - navbar badge class and docs
9c7d193
@dnil dnil mentioned this issue May 27, 2025
Merged
2 tasks
@northwestwitch
Copy link
Member

We could also have a shorter label, like "Dev GRCh37"

@dnil dnil closed this as completed in #5500 Jun 2, 2025
dnil added a commit that referenced this issue Jun 2, 2025
@dnil @northwestwitch
Fix #5499 - navbar badge class and docs (#5500)
be77892 
* Fix #5499 - navbar badge class and docs

* update changelog

* update changelog

---------

Co-authored-by: Chiara Rasi <rasi.chiara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnil dnil

Labels
docs QualityOfLife
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5499 - navbar badge class and docs Clinical-Genomics/scout
2 participants
@dnil @northwestwitch
0