Use a cache when figuring out if a pod target is test only #6787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d87678f to
73d8be7
Compare
dnkoutso
commented
Jun 7, 2017
lib/cocoapods/installer/analyzer.rb
Outdated
| if @analyzer_cache.key?(key) | ||
| return @analyzer_cache[key] | ||
| end | ||
| source = pod_targets.any? { |pt| pt.dependent_targets.map(&:name).include?(name) } |
There was a problem hiding this comment.
thoughts welcome on how to combine this perhaps and make it faster.
segiddins
reviewed
Jun 7, 2017
lib/cocoapods/installer/analyzer.rb
Outdated
| @@ -46,6 +46,7 @@ def initialize(sandbox, podfile, lockfile = nil) | |||
| @update = false | |||
| @allow_pre_downloads = true | |||
| @has_dependencies = true | |||
| @analyzer_cache = {} | |||
| end | |||
There was a problem hiding this comment.
Please name this after what it is caching
lib/cocoapods/installer/analyzer.rb
Outdated
| test = pod_targets.any? { |pt| pt.test_dependent_targets.map(&:name).include?(pod_target.name) } | ||
| !source && test | ||
| name = pod_target.name | ||
| key = [name, pod_targets] |
There was a problem hiding this comment.
Depending on how often this is hit, it might be worth using a struct as the key instead of an array
There was a problem hiding this comment.
Interesting. Will attempt it.
There was a problem hiding this comment.
@segiddins done! Still works :)
|
Fixed the naming problem and rubocop. Looking intro struct way but I think it might be OK anyway. |
|
✅ |
segiddins
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of CP 1.3.0.beta.1 this method would add 7-10 seconds to out pod install time.
This adds a cache to the result but also prevents a number of calls to this method if they are not needed by short circuiting earlier.
There are no tests for this PR because the logic is the same. I hot patched CocoaPods for us and the
pod installnow remains the same.