8000 Wrap `$PODS_CONFIGURATION_BUILD_DIR` and `$PODS_BUILD_DIR` with curlies by dnkoutso · Pull Request #7048 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wrap $PODS_CONFIGURATION_BUILD_DIR and $PODS_BUILD_DIR with curlies #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

Wrap $PODS_CONFIGURATION_BUILD_DIR and $PODS_BUILD_DIR with curlies #7048

merged 1 commit into from
Sep 22, 2017

Conversation

dnkoutso
Copy link
Contributor
@dnkoutso dnkoutso commented Sep 19, 2017 •
edited
Loading

This is consistent with everything else that uses variables by cocoapods but also fixes an issue where sometimes Xcode stomps the input paths due to the lack of {} around the env variable.

@dnkoutso
Copy link
Contributor Author

Will probably require integration specs update.

@dnkoutso dnkoutso mentioned this pull request Sep 19, 2017
Merged
@dnkoutso
Copy link
Contributor Author

Integration PR CocoaPods/cocoapods-integration-specs#122

@dnkoutso dnkoutso changed the title Wrap $PODS_CONFIGURATION_BUILD_DIR with curlies Wrap $PODS_CONFIGURATION_BUILD_DIR and $PODS_BUILD_DIR with curlies Sep 19, 2017
@dnkoutso dnkoutso added this to the 1.4.0 milestone Sep 19, 2017
@dnkoutso
Copy link
Contributor Author

rebased

paulb777
paulb777 approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orta orta merged commit 516124e into CocoaPods:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnkoutso @paulb777 @orta
0