8000 Build pod targets with script phases and integrate them properly by dnkoutso · Pull Request #7104 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build pod targets with script phases and integrate them properly #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2017
Merged

Build pod targets with script phases and integrate them properly #7104

merged 1 commit into from
Oct 5, 2017

Conversation

dnkoutso
Copy link
Contributor
@dnkoutso dnkoutso commented Oct 5, 2017 •
edited
Loading

Fixes two issues.

  1. A podspec without any sources would not even add a target even if it had a script phase or not. Now this is fixed.
  2. A pod target integrator was not being created unless the pod target had test specs in it. This is a bug since we still need to integrate targets that have script phases.

Both issues fixed.

@dnkoutso dnkoutso force-pushed the fix_pod_target_integration branch from c872056 to 911280b Compare October 5, 2017 20:20
@dnkoutso dnkoutso mentioned this pull request Oct 5, 2017
Closed
@dnkoutso dnkoutso added this to the 1.4.0 milestone Oct 5, 2017
@dnkoutso dnkoutso force-pushed the fix_pod_target_integration branch from 911280b to b6ee92e Compare October 5, 2017 20:24
@dnkoutso dnkoutso merged commit bd9e7f4 into CocoaPods:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@justinseanmartin justinseanmartin Awaiting requested review from justinseanmartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkoutso @paulb777
0