Avoid 'Unspecified' value for SWIFT_VERSION build settings #7109

heyzooi · 2017-10-06T16:45:04Z

Avoid 'Unspecificed' value for SWIFT_VERSION build settings
Making Swift 3.2 the default value since this is the minimum version supported by Xcode 9

…supported by Xcode 9

dnkoutso · 2017-10-06T17:06:29Z

CHANGELOG.md

@@ -50,6 +50,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
  [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
  [#7081](https://github.com/CocoaPods/CocoaPods/issues/7081)

+* Avoid 'Unspecificed' value for SWIFT_VERSION build settings and make 'Swift 3.2' the default value


typo, Unspecified

thanks... fixing it!

dnkoutso · 2017-10-06T17:07:41Z

lib/cocoapods/validator.rb

@@ -470,7 +470,7 @@ def install_pod
          next unless (native_target = pod_target.native_target)
          native_target.build_configuration_list.build_configurations.each do |build_configuration|
            (build_configuration.build_settings['OTHER_CFLAGS'] ||= '$(inherited)') << ' -Wincomplete-umbrella'
-            build_configuration.build_settings['SWIFT_VERSION'] = swift_version if pod_target.uses_swift?
+            build_configuration.build_settings['SWIFT_VERSION'] = swift_version if pod_target.uses_swift? && !swift_version.nil?


is there a test that covers the !swift_version.nil? part? If not can you please add one?

i'm not a ruby developer, i will try my best to write unit tests

not a problem! There are plenty of examples around the *_spec.rb for the class you are writing a test for you can cargo cult from.

i'm trying to figure out how to run unit tests in ruby. reading this tutorial here: https://code.tutsplus.com/tutorials/ruby-for-newbies-testing-with-rspec--net-21297
but i'm getting this error:

/Users/victor/.rvm/gems/ruby-2.0.0-p648/gems/rspec-core-3.6.0/lib/rspec/core/formatters.rb:206:in `built_in_formatter': cannot load such file -- rspec/core/formatters/progress_formatter (LoadError)

googling it to figure out how to fix it. if know the solution, please let me know please.

nvm... i figured how to run bundle exec bacon ...

you can also run bundle exec rake spec or bundle exec rake spec:unit for only unit tests

@heyzooi can you provide a case where the part !swift_version.nil? can be true?

dnkoutso · 2017-10-06T17:07:52Z

lib/cocoapods/generator/app_target_helper.rb

@@ -100,7 +100,7 @@ def self.add_xctest_search_paths(target)
      #
      def self.add_swift_version(target, swift_version)
        target.build_configurations.each do |configuration|
-          configuration.build_settings['SWIFT_VERSION'] = swift_version
+          configuration.build_settings['SWIFT_VERSION'] = !swift_version.nil? ? swift_version : Validator::DEFAULT_SWIFT_VERSION


needs a test

Nit pick here, rather than checking for nil in each loop, could the desired value be extracted to before the loop? Something like

version_to_set = swift_version || Validator::DEFAULT_SWIFT_VERSION target.build_configurations.each do |configuration| configuration.build_settings['SWIFT_VERSION'] = version_to_set end

sure! let me do that

dnkoutso · 2017-10-06T17:08:11Z

lib/cocoapods/project.rb

@@ -25,6 +25,9 @@ def initialize(path, skip_initialization = false,
      @pods = new_group('Pods')
      @development_pods = new_group('Development Pods')
      self.symroot = LEGACY_BUILD_ROOT
+      root_object.build_configuration_list.build_configurations.each do |config|


why do we care for the entire project to set this value? It seems that each and every other pod target that uses swift should use a value now.

if you don't specify a value for the SWIFT_VERSION build settings, Xcode will not compile, so the idea here was to set a default version and allow each pod to override the default version as needed.

@heyzooi doesnt each pod that uses swift automatically get assigned a version? I am still not 100% convinced we need to be changing the project configuration in this PR.

amorde · 2017-10-06T18:15:16Z

spec/unit/validator_spec.rb

@@ -894,10 +894,10 @@ def test_swiftpod_with_dot_swift_version(version = '3.1.0')
      end

      describe '#swift_version' do
-        it 'defaults to Swift 3.0' do
+        it 'defaults to Swift 3.2' do


There is a test right above this that contains a warning message starting with The validator for Swift projects uses Swift 3.0 by default - could that test (and possibly the code that generates that warning) be updated as well?

Edit: this is now fixed

heyzooi · 2017-10-06T20:14:12Z

hey guys, how do I link the cocoapods-integration-specs submodule to this PR CocoaPods/cocoapods-integration-specs#125?

amorde · 2017-10-06T21:28:17Z

@heyzooi That PR needs to be accepted before this one, then update the git submodule reference to point to the latest commit

dnkoutso · 2017-10-12T17:16:27Z

examples/TestInclusions/TestInclusions/Base.lproj/Main.storyboard

@@ -1,8 +1,12 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>


does this file need to change?

dnkoutso · 2017-10-12T17:18:35Z

This change we should overall land but there are still a few questions remaining before we do so.

dnkoutso · 2017-10-12T17:22:49Z

lib/cocoapods/generator/app_target_helper.rb

@@ -99,8 +99,9 @@ def self.add_xctest_search_paths(target)
      # @return [void]
      #
      def self.add_swift_version(target, swift_version)
+        version_to_set = !swift_version.nil? ? swift_version : Validator::DEFAULT_SWIFT_VERSION


Not sure this belongs in this method. If it does it most certainly needs documentation update.

I still need to clearly understand a case in which in validator.rb...

# @return [String] the SWIFT_VERSION to use for validation. # def swift_version return @swift_version if defined?(@swift_version) if version = dot_swift_version @swift_version = version else DEFAULT_SWIFT_VERSION end end

...can return nil? Is it if the contents of the .swift-version file are empty?

if .swift-version is empty, it returns nil, and goes to DEFAULT_SWIFT_VERSION

So yes I don't see the reason why we are doing a nil? check here and in the other place, @heyzooi

dnkoutso · 2017-10-13T22:52:06Z

@heyzooi I am going to decline this PR in favor of #7136. I gave you credit in this other PR.

I verified that with Xcode 9 I no longer see "Unsupported" version for Swift and instead defaults to 3.2.

I do not think the remaining changes in this PR as necessary.

piemonte · 2017-10-13T23:48:13Z

as of recent, i've encountered this issue with the following project:

📎 https://github.com/piemonte/player

even though i have a .swift-verision and properly specified project file, linting still seems to fail. i haven't been able to push the latest release.

dnkoutso · 2017-10-13T23:49:09Z

@piemonte are you on 1.4.0.beta.1? There was a regression in setting Swift version entirely for the project which was fixed in #7131 but it has not been released yet.

piemonte · 2017-10-14T00:34:01Z

@dnkoutso ah, yes, i am. you're awesome, thanks for the link.

heyzooi added 3 commits October 6, 2017 09:44

Avoid 'Unspecificed' value for SWIFT_VERSION build settings

ca860e2

making Swift 3.2 the default value since this is the minimum version …

5375386

…supported by Xcode 9

including CHANGELOG entry to credit yourself

2769dc7

dnkoutso reviewed Oct 6, 2017

View reviewed changes

heyzooi changed the title ~~Avoid 'Unspecificed' value for SWIFT_VERSION build settings~~ Avoid 'Unspecified' value for SWIFT_VERSION build settings Oct 6, 2017

dnkoutso reviewed Oct 6, 2017

View reviewed changes

typo 'Unspecified'

1df708d

dnkoutso reviewed Oct 6, 2017

View reviewed changes

amorde reviewed Oct 6, 2017

View reviewed changes

heyzooi mentioned this pull request Oct 6, 2017

necessary changes for CocoaPods PR #7109 CocoaPods/cocoapods-integration-specs#125

Closed

heyzooi mentioned this pull request Oct 7, 2017

Lint Error for pod library Swift 4 Xcode 9 #7098

Closed

heyzooi added 2 commits October 10, 2017 14:24

updating specs to use Swift 3.2 as the default version

25d5455

updating specs to use Swift 3.2 as the default version

609b8bc

dnkoutso reviewed Oct 12, 2017

View reviewed changes

amorde mentioned this pull request Oct 12, 2017

Better warning message for which Swift version was used during validation #7131

Merged

dnkoutso mentioned this pull request Oct 13, 2017

Update default Swift version to 3.2 for validation #7136

Merged

dnkoutso closed this Oct 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid 'Unspecified' value for SWIFT_VERSION build settings #7109

Avoid 'Unspecified' value for SWIFT_VERSION build settings #7109

		@@ -1,8 +1,12 @@
		<?xml version="1.0" encoding="UTF-8" standalone="no"?>

Avoid 'Unspecified' value for SWIFT_VERSION build settings #7109

Avoid 'Unspecified' value for SWIFT_VERSION build settings #7109

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment