Warn when a pod that was added or changed includes script phases #7110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
845d310 to
588825e
Compare
dnkoutso
commented
Oct 6, 2017
| # @return [Array<Library>] The targets of the development pods generated by | ||
| # the installation process. | ||
| # | ||
| def development_pod_targets |
There was a problem hiding this comment.
FYI be careful when saying "unused method" - it might have been used by client scripts, not necessarily from within Cocoapods. This commit broke my scripting because I was depending on development_pod_targets being exposed.
There was a problem hiding this comment.
Likewise this broke our scripts. I think chang 8000 es like this should go in the ChangeLog.
There was a problem hiding this comment.
@dnkoutso ^^ this might be more impactful for others that switch to 1.4.0
There was a problem hiding this comment.
Ill add it back and include a comment. Will be in rc.2
588825e to
f76fba1
Compare
orta
approved these changes
Oct 6, 2017
f76fba1 to
bd809d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users must be aware if pods are adding script phases during installation. This is intended not to be a solution for protecting the user's system but provide visibility to the user who must inspect the script phase.