8000 Add option to app host installer whether or not ot add a main by dostrander · Pull Request #8235 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add option to app host installer whether or not ot add a main #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2018
Merged

Add option to app host installer whether or not ot add a main #8235

merged 6 commits into from
Nov 2, 2018

Conversation

dostrander
Copy link
Contributor
  • App specs should not add main

@dostrander
Copy link
Contributor Author

@segiddins @dnkoutso

dnkoutso
dnkoutso reviewed Oct 31, 2018
View reviewed changes
CHANGELOG.md Outdated
* Add documentation for the Podfile installation options
[Eric Amorde](https://github.com/amorde)
[#8198](https://github.com/CocoaPods/CocoaPods/issues/8198)
[guides.cocoapods.org #142](https://github.com/CocoaPods/guides.cocoapods.org/issues/142)

* Adds app spec project integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha I think I already took care of that in another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do not need this change at all.

dnkoutso
dnkoutso reviewed Oct 31, 2018
View reviewed changes
lib/cocoapods/installer/xcode/pods_project_generator/app_host_installer.rb Outdated
@@ -33,6 +33,10 @@ class AppHostInstaller
#
attr_reader :app_target_label

# @return [Boolean] whether the app host installer should add main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a main.m file

@dostrander dostrander force-pushed the dostrander/dont-add-main-appspecs branch from 737e88b to 75cfde8 Compare October 31, 2018 15:36
segiddins
segiddins approved these changes Nov 1, 2018
View reviewed changes
lib/cocoapods/installer/xcode/pods_project_generator/app_host_installer.rb Outdated
#
def initialize(sandbox, project, platform, subgroup_name, group_name, app_target_label)
def initialize(sandbox, project, platform, subgroup_name, group_name, app_target_label, add_main = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add_main_file: true

@dostrander dostrander force-pushed the dostrander/dont-add-main-appspecs branch from 75cfde8 to b36ed84 Compare November 2, 2018 15:50
@dostrander dostrander force-pushed the dostrander/dont-add-main-appspecs branch from e04dfff to 566fd47 Compare November 2, 2018 20:32
@dnkoutso dnkoutso added this to the 1.7.0 milestone Nov 2, 2018
@dnkoutso dnkoutso merged commit 53a3fac into CocoaPods:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dostrander @dnkoutso @segiddins
0