Extract project writing into a new object. #8247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Extract project writing into a new object.
[sebastianv1](https://github.com/sebastianv1)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
segiddins
reviewed
Nov 6, 2018
|
|
||
| def write! | ||
| UI.message "- Writing Xcode project file to #{UI.path @sandbox.project_path}" do | ||
| @project.pods.remove_from_project if @project.pods.empty? |
There was a problem hiding this comment.
use methods for access here instead of ivars
dnkoutso
reviewed
Nov 6, 2018
lib/cocoapods/installer.rb
Outdated
| @@ -210,7 +210,10 @@ def generate_pods_project(generator = create_generator) | |||
| @target_installation_results = pod_project_generation_result.target_installation_results | |||
| @pods_project = pod_project_generation_result.project | |||
| run_podfile_post_install_hooks | |||
| generator.write(@pods_project, @target_installation_results) | |||
| project_writer = Xcode::PodsProjectWriter.new(@sandbox, @pods_project, | |||
There was a problem hiding this comment.
and here no need to use ivars again
05aef52 to
386826a
Compare
This extracts writing and cleaning up a `Project` out of `PodsProjectGenerator` and into its own object called `PodsProjectWriter`.
386826a to
ec164bf
Compare
segiddins
approved these changes
Nov 6, 2018
dnkoutso
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts writing and cleaning up a
Projectout ofPodsProjectGeneratorand into its own object calledPodsProjectWriter.