Extract project creation and preparation into new object #8243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
726db29 to
63487df
Compare
Here's an example of your CHANGELOG entry: * Extract project creation and preparation into new object
[sebastianv1](https://github.com/sebastianv1)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
amorde
approved these changes
Nov 2, 2018
| object_version = @aggregate_targets.map(&:user_project).compact.map { |p| p.object_version.to_i }.min | ||
| project_generator = ProjectGenerator.new(@sandbox, project_path, @pod_targets, build_configurations, | ||
| platforms, object_version, @config.podfile_path) | ||
| @project = project_generator.generate! |
There was a problem hiding this comment.
does the project need to be stored in the generator if its included in the generation result?
There was a problem hiding this comment.
Ah good catch. No it doesn't.
c692722 to
72e0ba1
Compare
72e0ba1 to
bc8da6b
Compare
dnkoutso
reviewed
Nov 6, 2018
| @@ -59,7 +60,15 @@ def initialize(sandbox, aggregate_targets, pod_targets, analysis_result, install | |||
| end | |||
|
|
|||
| def generate! | |||
| project = prepare | |||
| project_path = sandbox.project_path | |||
| build_configurations = @analysis_result.all_user_build_configurations | |||
There was a problem hiding this comment.
you dont have to use the ivars here at all. You can remove the @ for most of these
dnkoutso
reviewed
Nov 6, 2018
| # | ||
| attr_reader :sandbox | ||
|
|
||
| # @return [#to_s] path |
There was a problem hiding this comment.
was it [#to_s] before? Can be String?
There was a problem hiding this comment.
Yeah String is probably better
dnkoutso
reviewed
Nov 6, 2018
| # | ||
| def generate! | ||
| project = create_project(@path, @object_version) | ||
| prepare(@sandbox, project, @pod_targets, @build_configurations, @platforms, @podfile_path) |
There was a problem hiding this comment.
same here you can use sandbox and pod_targets etc no ivar
segiddins
approved these changes
Nov 6, 2018
83d16e0 to
05783d3
Compare
The object `ProjectGenerator` is repsonsible for creating a new `Pod::Project` and preparing it's structure from the build configurations, platforms, and pod targets.
05783d3 to
51cc044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
53CC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object
ProjectGeneratoris now repsonsible for creating a newPod::Projectand preparing it's structure from the build configurations, platforms, and pod targets.