Add CDN repo Source to allow retrieving specs from a web URL #8280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor of us getting these in as a way to allow beta-testing the CDN approach on a larger scale, but ideally I'd like this to live in the next release. Do we (as CP core) have an idea how long it'll be till we start moving to |
|
1.6.0 is still in beta but we are planning an rc this week or next. I'd imagine 1.7.0 beta would go through mid-Dec to mid January (with holidays etc) |
segiddins
reviewed
Nov 15, 2018
segiddins
reviewed
Nov 17, 2018
|
So I ended up doing all the optimizations in the Core CDNSource class. This minimizes the coupling between the two modules. |
amorde
reviewed
Nov 18, 2018
segiddins
reviewed
Nov 21, 2018
|
Sure! I'm having trouble figuring out where to add this spec, though, or what to base it on. Can you help me out? |
dnkoutso
approved these changes
Nov 26, 2018
amorde
approved these changes
Nov 28, 2018
49e62b7 to
1a06fa8
Compare
segiddins
approved these changes
Dec 15, 2018
This was referenced Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8268, I am submitting an initial draft of the CDN source implementation.
Please note that at this point, the implementation is purely additive, and does not interfere with traditional spec repo retrieval.
There's a corresponding PR in Core that needs to be merged first.
The tests on travis will fail because of Core integration, but I've hacked together another branch to show that everything passes. As soon as the Core PR is merged, the tests here will pass as well.